Attention is currently required from: plaisthos.

flichtenheld has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/746?usp=email )

Change subject: Move cipher/data-ciphers warning to D_LOW (verb 4)
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

File src/openvpn/options.c:

http://gerrit.openvpn.net/c/openvpn/+/746/comment/30ce7242_48e36053 :
PS3, Line 3558:         msg(D_LOW, "DEPRECATED OPTION: --cipher set to '%s' but 
missing in "
I do not agree with this part of the patch. Since this only happens if you have 
a --cipher in your config I think it is fine to keep this warning. I would only 
reduce the other one since that is basically a warning about the recommended 
config.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/746?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie2797a82ad769cb640440d1ba7dfeb416e7b932d
Gerrit-Change-Number: 746
Gerrit-PatchSet: 3
Gerrit-Owner: plaisthos <arne-open...@rfc2549.org>
Gerrit-Reviewer: cron2 <g...@greenie.muc.de>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Comment-Date: Fri, 27 Dec 2024 12:24:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to