Attention is currently required from: flichtenheld, its_Giaan, ordex, plaisthos.

cron2 has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/762?usp=email )

Change subject: override ai_family if 'local' numeric address was specified
......................................................................


Patch Set 7: Code-Review-2

(1 comment)

Patchset:

PS7:
Hah, how annoying.

The client-side behaviour is fine (changing "a mismatch of proto and literal 
address will fail" to "upgrade to the other proto"), but the *server* side 
behaviour breaks all my dual-stack servers.

So a config with

```
port 51194
proto udp6
```

(no `local` statement whatsoever, so "ANY") ends up IPv4-only

```
$ netstat -an |grep 51194
udp        0      0 0.0.0.0:51194           0.0.0.0:*         
```

... which is inacceptable.  (This is FreeBSD output, which clearly 
differentiates between "udp", "udp6" and "0.0.0.0:51194" vs. ":::51194").  Meh.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/762?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie2471e6b2d6974e70423b09918ad1c2136253754
Gerrit-Change-Number: 762
Gerrit-PatchSet: 7
Gerrit-Owner: its_Giaan <gianma...@mandelbit.com>
Gerrit-Reviewer: cron2 <g...@greenie.muc.de>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: ordex <a...@unstable.cc>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: its_Giaan <gianma...@mandelbit.com>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Attention: ordex <a...@unstable.cc>
Gerrit-Comment-Date: Tue, 24 Dec 2024 13:54:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to