v1 looked like a nice and trivial change with not much to go wrong, and
then GHA exploded - one of the builds runs without "-O2", and with
an inline function without "static inline" this leads to link time
errors (function is not inlined due to missing -O2, but not instantiated
either, so "nowhere to be found"). v1 to v2 only differ in the "static",
so I'm recording Frank's ACK on v1 plus adding my own.
Your patch has been applied to the master branch.
commit d92df90470a059f0ea231250d85ab47b72bc4791
Author: Heiko Hund
Date: Sat Dec 21 23:41:36 2024 +0100
service: add utf8to16 function that takes a size
Signed-off-by: Heiko Hund <he...@ist.eigentlich.net>
Acked-by: Frank Lichtenheld <fr...@lichtenheld.com>
Acked-by: Gert Doering <g...@greenie.muc.de>
Message-Id: <20241221224136.20984-1-g...@greenie.muc.de>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30158.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
