It's not immediately obvious to me why this is a useful change (except "do not copy structs around if not needed"), but the actual change looks good and should not change operational behaviour in any way - no memory handling or anything involved, just "the midlayer" function referencing structure elements via pointer now.
Compile tested :-) Your patch has been applied to the master branch. commit db46d4d38bec59435a76bb0968d530b9426c551e Author: Heiko Hund Date: Fri Dec 13 17:46:30 2024 +0100 dns: clone options via pointer instead of copy Signed-off-by: Heiko Hund <he...@ist.eigentlich.net> Acked-by: Frank Lichtenheld <fr...@lichtenheld.com> Message-Id: <20241213164630.266045-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30112.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel