Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/828?usp=email )
Change subject: Allow DEFAULT in data-ciphers and report both expanded and user set option ...................................................................... Patch Set 1: (5 comments) File doc/man-sections/protocol-options.rst: http://gerrit.openvpn.net/c/openvpn/+/828/comment/51d7502e_31b1c083 : PS1, Line 181: Starting with OpenVPN 2.7 the special keyword DEFAULT can be used in the > Probably makes sense to use ``DEFAULT`` here. Done File src/openvpn/multi.c: http://gerrit.openvpn.net/c/openvpn/+/828/comment/d1714501_fb5ceee1 : PS1, Line 1905: "Server data-ciphers: '%s'%s, client supports cipher '%s'", > make consistent with the other case. Either '%s%s' or '%s'%s, but not both. Done File src/openvpn/ssl_ncp.h: http://gerrit.openvpn.net/c/openvpn/+/828/comment/0e004a12_dc41d0f5 : PS1, Line 174: * The returned string will be allocated in the passed \param gc > If you want to format a word as param use \p, \param is for documenting > parameters. I will use \c since \c and \p are the same according to documentation and seem to use \c rather than \p in OpenVPN 2.x File src/openvpn/ssl_ncp.c: http://gerrit.openvpn.net/c/openvpn/+/828/comment/711f6f13_504c6970 : PS1, Line 537: * Replaces the string DEFAULT with the string \param replace. The > \p Done File tests/unit_tests/openvpn/test_ncp.c: http://gerrit.openvpn.net/c/openvpn/+/828/comment/b36dcfd7_095812e3 : PS1, Line 356: test_ncp_expand(void **state) > I would suggest to add a testcase here where ncp_cipher_conf contains DEFAULT > but is not equal to DE […] added -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/828?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia1c5209022d3ab4c0dac6438c41891c7d059f812 Gerrit-Change-Number: 828 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Thu, 19 Dec 2024 18:05:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
