This might be the patch with the larges amount of ACKs and confusion
in Gerrit :-) - we do have lots of +2 and then gerrit forgot some on
pushing a new version, and I complained about ASSERT()... but in the
end, the crypto bits have been thoroughly reviewed by MaxF, Steffan
and Antonio, and I have complained sufficiently about the memcpy()
and ASSERT() parts for v10...
v8 (which is identical except for the ASSERT()) has been through
full client/server interop testing, so I did only basic testing on v10.
Your patch has been applied to the master branch.
commit baa9192851006e2dbb90b410011e61ecf2e01870
Author: Arne Schwabe
Date: Thu Dec 12 15:38:45 2024 +0100
Use XOR instead of concatenation for calculation of IV from implicit IV
Signed-off-by: Arne Schwabe <a...@rfc2549.org>
Acked-by: MaxF <m...@max-fillinger.net>
Acked-by: Antonio Quartulli <anto...@mandelbit.com>
Acked-by: Steffan Karger <stef...@karger.me>
Acked-by: Gert Doering <g...@greenie.muc.de>
Message-Id: <20241212143845.4090-1-g...@greenie.muc.de>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30097.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
