Stared-at-code, and gave it a quick test with "--reneg-bytes 20000" again
(on FreeBSD/amd64).  BB has also tested this on NetBSD/i386, so 32bit 
systems are also fine.  Testing with 2^65 leads to

2024-11-11 15:03:54 TLS: soft reset sec=30/30 bytes=578818/9223372036854775807 
pkts=550/0

.. which should be good enough in terms of error handling, I think
(it's truncating to 2^63-1).  We can revisit this if this is a relevant
distinction for "number of packets until we need to renegotiate".

Your patch has been applied to the master branch.

commit d52ea247d9dec5262a09f3891db83b79b2ca403e
Author: Arne Schwabe
Date:   Mon Nov 11 10:40:33 2024 +0100

     Change --reneg-bytes and --reneg-packets to 64 bit counters

     Signed-off-by: Arne Schwabe <a...@rfc2549.org>
     Acked-by: Gert Doering <g...@greenie.muc.de>
     Message-Id: <20241111094033.16073-1-g...@greenie.muc.de>
     URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg29744.html
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to