Stared at the code, compared all the individual conditions before/after,
reasonably sure it does the same thing. Tested a few cases
(--reneg-sec 151, --reneg-pkts 20, --reneg-bytes 10000).
Noticed an interesting inconsistency...
2024-11-11 08:55:36 TLS: soft reset sec=151/151 bytes=7002/-1 pkts=74/0
.. "bytes" is initialized to -1 if not used, "pkts" to "0", and
the code also does "> 0" vs. "!= 0" (implicit)... but this is as it
was before, so not a change this patch introduces.
I have fixed the broken indentation (uncrustify build fail) on the fly,
"just one space to add".
Your patch has been applied to the master branch.
commit a4d0de10883fbec691a0301dd6fa04b095664711
Author: Arne Schwabe
Date: Mon Nov 11 08:43:55 2024 +0100
Move should_trigger_renegotiation into its own function
Signed-off-by: Arne Schwabe <a...@rfc2549.org>
Acked-by: Gert Doering <g...@greenie.muc.de>
Message-Id: <20241111074355.17918-1-g...@greenie.muc.de>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg29740.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
