Attention is currently required from: cron2, flichtenheld, plaisthos.

ordex has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/793?usp=email )

Change subject: send uname() release as IV_PLAT_VER= on non-windows versions
......................................................................


Patch Set 3: Code-Review+1

(3 comments)

Patchset:

PS3:
a few nit about the commit message, but patch looks good


File doc/man-sections/client-options.rst:

http://gerrit.openvpn.net/c/openvpn/+/793/comment/9d2f23e6_9a5474d9 :
PS3, Line 435:         field.  Quite often this is the operation system kernel
s/operation/running ?


http://gerrit.openvpn.net/c/openvpn/+/793/comment/df21cbed_519010f8 :
PS3, Line 435:         field.  Quite often this is the operation system kernel
syscall manual is 2 - at least on my gentoo. man 3 uname leads to nothing



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/793?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Id2b0c5a517f02e5c219fea2ae3ef2bdef7690169
Gerrit-Change-Number: 793
Gerrit-PatchSet: 3
Gerrit-Owner: cron2 <g...@greenie.muc.de>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: ordex <a...@unstable.cc>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: cron2 <g...@greenie.muc.de>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Comment-Date: Sun, 03 Nov 2024 20:56:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to