Attention is currently required from: flichtenheld, mattock, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/775?usp=email )
Change subject: t_server_null: forcibly kill misbehaving servers ...................................................................... Patch Set 3: Code-Review-2 (2 comments) Patchset: PS3: getting close... but I really think we should error out and include diagnostics if "kill -9" is necessary. File tests/t_server_null_server.sh: http://gerrit.openvpn.net/c/openvpn/+/775/comment/e8a12af1_7c789c6a : PS3, Line 106: fi I think we should make this a "test fail". If the server needs to be hard killed, something is wrong with the server, and we should look in the (soon-persistent :-) ) logs. Maybe we could even output a "tail -20" or so of the logfile in this case, so failures can be investigated without logging into the machine? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/775?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ic0f98cd3b87a7b86e032e63167ac9036f7c08fcb Gerrit-Change-Number: 775 Gerrit-PatchSet: 3 Gerrit-Owner: mattock <sam...@openvpn.net> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: mattock <sam...@openvpn.net> Gerrit-Comment-Date: Wed, 23 Oct 2024 20:57:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
