I've lightly tested this on the server testbed (it has TCP listeners,
and extensive t_client tests - everyhing is fine), and also stared a
bit at the code (which seems reasonable, and Frank has more extensibly
reviewed it already).
There's some questions I do not understand (like, why not store the ev_arg
in the event structure? why pass the ev_arg to socket_set_listen_persistent()
when it is passed the socket itself already?) but I guess there's good
reasons for it...
Your patch has been applied to the master branch.
commit cd8e25a6e9a0fc3687cf8b9df460885db2aee566 (master)
Author: Antonio Quartulli
Date: Wed Oct 23 10:08:52 2024 +0200
event/multi: add event_arg object to make event handling more generic
Signed-off-by: Antonio Quartulli <a...@unstable.cc>
Signed-off-by: Gianmarco De Gregori <gianma...@mandelbit.com>
Acked-by: Frank Lichtenheld <fr...@lichtenheld.com>
Message-Id: <20241023080853.3710-1-g...@greenie.muc.de>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg29602.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
