Attention is currently required from: its_Giaan, ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/434?usp=email )
Change subject: allow tcp/udp server to listen on multiple ports at the same time ...................................................................... Patch Set 5: Code-Review-2 (19 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/434/comment/d86891df_56a16db7 : PS5, Line 7: allow tcp/udp server to listen on multiple ports at the same time For a change this fundamental this commit message is not enough. At least it should answer whether this actually changes any default behavior? Is there a way to use this functionality with only this patch? Patchset: PS5: Could definitely use - a cleanup of old code styles - some more commit message - some more doxygen documentation - a discussion about alternatives to 25 parameters to a function File src/openvpn/forward.h: http://gerrit.openvpn.net/c/openvpn/+/434/comment/43fc1b4c_0009fdae : PS5, Line 239: void process_incoming_tun(struct context *c, struct link_socket *out_ls); I think we have implicitly agreed to call those out_sock? http://gerrit.openvpn.net/c/openvpn/+/434/comment/e3e073d2_b0854f7c : PS5, Line 311: struct link_socket *ls); let's stick with sock to be consistent? File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/434/comment/3c2f7cf8_7db546e8 : PS5, Line 67: for (i = 0; i < c->c1.link_sockets_num; i++) move declaration here. http://gerrit.openvpn.net/c/openvpn/+/434/comment/83bc5910_ce7ee80d : PS5, Line 1500: out_ls); this looks weird, why the additional line break? http://gerrit.openvpn.net/c/openvpn/+/434/comment/d8921253_6d30716c : PS5, Line 2091: int i; no File src/openvpn/init.c: http://gerrit.openvpn.net/c/openvpn/+/434/comment/8bed9745_e6009f9c : PS5, Line 2712: int i; no http://gerrit.openvpn.net/c/openvpn/+/434/comment/1745f5ec_89e42cd1 : PS5, Line 2726: int i; no http://gerrit.openvpn.net/c/openvpn/+/434/comment/8933303c_7cb6783c : PS5, Line 3809: int i; no http://gerrit.openvpn.net/c/openvpn/+/434/comment/6a0a8d89_cbd88193 : PS5, Line 3830: int i; no http://gerrit.openvpn.net/c/openvpn/+/434/comment/18ba15df_e611be9f : PS5, Line 3898: int i; no http://gerrit.openvpn.net/c/openvpn/+/434/comment/586e53d7_2687f6bd : PS5, Line 4059: int i; no File src/openvpn/mtcp.c: http://gerrit.openvpn.net/c/openvpn/+/434/comment/03032190_4dfe1132 : PS5, Line 265: int status, i; no File src/openvpn/mudp.c: http://gerrit.openvpn.net/c/openvpn/+/434/comment/420473bb_c732efd1 : PS5, Line 384: int i; no File src/openvpn/multi.h: http://gerrit.openvpn.net/c/openvpn/+/434/comment/d01c4e19_c10b5176 : PS5, Line 133: bool did_open_context; doxygen for new members please File src/openvpn/socket.h: http://gerrit.openvpn.net/c/openvpn/+/434/comment/ffde4105_327f32dd : PS5, Line 348: link_socket_init_phase1(struct link_socket *sock, hmm, no? There must be some better way than an function that has 25 parameters, surely? http://gerrit.openvpn.net/c/openvpn/+/434/comment/adb96022_106a698b : PS5, Line 1288: bool sockets_read_residual(const struct context *c); please add minimal documentation File src/openvpn/socket.c: http://gerrit.openvpn.net/c/openvpn/+/434/comment/a2a2981b_f791c838 : PS5, Line 2239: #if defined (_WIN32) ?? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/434?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia0a889e800f0b36aed770ee36e31afeec5df6084 Gerrit-Change-Number: 434 Gerrit-PatchSet: 5 Gerrit-Owner: ordex <a...@unstable.cc> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: its_Giaan <gianma...@mandelbit.com> Gerrit-Attention: ordex <a...@unstable.cc> Gerrit-Comment-Date: Fri, 11 Oct 2024 16:45:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
