Attention is currently required from: flichtenheld, mattock, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/776?usp=email )
Change subject: t_server_null: persist test log files ...................................................................... Patch Set 1: Code-Review-1 (4 comments) Patchset: PS1: needs a bit of polish File tests/t_server_null_server.sh: http://gerrit.openvpn.net/c/openvpn/+/776/comment/186bd796_c642bb4c : PS1, Line 7: log="${server_name}.log" maybe just do `log="$t_server_null_logdir/$server_name.log"` here, to avoid having to repeat the "logdir" part below? http://gerrit.openvpn.net/c/openvpn/+/776/comment/3986d2c5_84d97934 : PS1, Line 12: rm -f "${status}" "${log}" "${pid}" I'd remove this line - at least removing ${log} is not serving a useful purpose anymore, but also removing the other files is just "needless code" as OpenVPN will create them new anyway http://gerrit.openvpn.net/c/openvpn/+/776/comment/52f6e109_1d63b541 : PS1, Line 20: $RUN_SUDO rm -f "${status}" "${log}" "${pid}" same here -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/776?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I49f1e7d25edb62bf202ffceb45dedc213f2eafdd Gerrit-Change-Number: 776 Gerrit-PatchSet: 1 Gerrit-Owner: mattock <sam...@openvpn.net> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: mattock <sam...@openvpn.net> Gerrit-Comment-Date: Fri, 04 Oct 2024 07:06:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
