Attention is currently required from: plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/770?usp=email )
Change subject: Fix socketpair return status not being checked in port share code ...................................................................... Patch Set 2: Code-Review-1 (1 comment) File src/openvpn/ps.c: http://gerrit.openvpn.net/c/openvpn/+/770/comment/299616be_4ad3018f : PS2, Line 854: if (!(socketpair(PF_UNIX, SOCK_DGRAM, 0, fd) == 0)) can we please not do double-negate-conditions for standard syscall return value checking?? `== -1` or `<0` is perfectly fine, according to the manpage. My brain hurts. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/770?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Id99a3ba13c0f1d0bc7e4699fb67ee9dff6221639 Gerrit-Change-Number: 770 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Comment-Date: Thu, 26 Sep 2024 12:58:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
