Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/772?usp=email )
Change subject: Remove null check after checking for checking for did_open_tun ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Indeed, this patch makes sense - if it would be NULL, the check is too late, so in this place it does not add anything useful. After staring at the code for quite some time I am reasonably convinced that c2.did_open_tun will only be set if `do_open_tun()` was called, which will either have a previously-set tuntap or will allocate a new one in `do_init_tun()`. `do_close_tun()` seems to be the only code path that could set `tuntap = NULL` (and it does not clear `did_open_tun`), but it is only called in sequences where it's either reopened right away, or where the instance ends for good. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/772?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I9966636163c7dfa208d26f1cadbf5b81937f3a34 Gerrit-Change-Number: 772 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Wed, 25 Sep 2024 15:10:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
