Attention is currently required from: its_Giaan, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/524?usp=email )
Change subject: Route: add support for user defined routing table ...................................................................... Patch Set 6: Code-Review-1 (1 comment) Patchset: PS6: Still not there - I think the code in `route.c` is much more complex than it needs to be. So with the new patch to `options.c`, we pass the to-be-used routing table ID to `add_route_to_option_list()`, so every route option always(!) has a routing-table to be used (or 0). This should be sufficient. But then, we have a default table_id added in `init_route()`, a number of extra flags (`RT_TABLE_DEFINED` for `r->flags`) etc., which is all not used in the end because even without the flag, `table_id` would become 0 in `add_route()` (by means of `r->table_id` being 0)...? So.. can we do this with half the code? Getting rid of all new DEFINEs, all new arguments and flags to `route_list` things, just storing the table id in `struct route_ipv4` and `struct route_ipv6`)= -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/524?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3e4ebef484d2a04a383a65ede5617ee98bf218a7 Gerrit-Change-Number: 524 Gerrit-PatchSet: 6 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: its_Giaan <gianma...@mandelbit.com> Gerrit-Comment-Date: Thu, 19 Sep 2024 10:40:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
