Attention is currently required from: flichtenheld, mrbff, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/731?usp=email )
Change subject: tun: removed unnecessary route installations
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Patchset:
PS3:
So, since I'm the one that wrote the original code, I went out to thoroughly
test this ("our buildbots succeed", is, unfortunately, not completely
indicative as I push an encompassing /48 route - so even if the /64 fails to
get installed, things would still work). Test with t_client setup + added
"--route-nopull" so you'll only get the connected routes, and then see if
server tun/tap IPv6 address still pings.
NetBSD: without the patch, error message on "route add", with the patch,
everything works - no error messages anymore.
OpenBSD: no error message, just double connected /64 route with different flags
(UCn vs. UGS). With the patch, everything works, no double routes.
MacOS (13.6.7): similar to NetBSD - without the patch, error message on "route
add", with the patch, everything works. Could not test TAP mode, as system
security gets in the way.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/731?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I235891212b15277349810913c9c1763da5c48587
Gerrit-Change-Number: 731
Gerrit-PatchSet: 3
Gerrit-Owner: mrbff <ma...@mandelbit.com>
Gerrit-Reviewer: cron2 <g...@greenie.muc.de>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Attention: mrbff <ma...@mandelbit.com>
Gerrit-Comment-Date: Thu, 12 Sep 2024 14:23:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
