Attention is currently required from: flichtenheld. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/267?usp=email )
Change subject: Various fixes for -Wconversion errors ...................................................................... Patch Set 5: (2 comments) Patchset: PS5: I'll deal with it ASAP, but would ask you to look into link_socket_write*() as discussed on IRC. So yes it will make the patch larger, but if it makes things better aligned... File src/openvpn/socket.h: http://gerrit.openvpn.net/c/openvpn/+/267/comment/2bb2272e_c41da5d0 : PS5, Line 1184: static inline size_t this looks funny. `ssize_t` and keep the `-1`? (it's a whole call chain of `link_socket_write_*()` things, but somewhere underneath is a `write()` or `sendto()`, which both use `ssize_t`) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/267?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6818b153bdeb1eed65870af99b0531e95807fe0f Gerrit-Change-Number: 267 Gerrit-PatchSet: 5 Gerrit-Owner: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: cron2 <g...@greenie.muc.de> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Tue, 10 Sep 2024 10:56:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
