Attention is currently required from: cron2, plaisthos, selvanair. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/728?usp=email )
Change subject: Protect cached username, password and token on client ...................................................................... Patch Set 3: Code-Review+2 (2 comments) Patchset: PS3: Code change makes sense to me according to documentation. Have not tested it, though. File src/openvpn/auth_token.c: http://gerrit.openvpn.net/c/openvpn/+/728/comment/12180016_ce581ad3 : PS2, Line 307: ASSERT(up && !up->protected); > doesn't make sense to test for up here, when we used up->password in the line > above. Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/728?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I42e17e09a02f01aedadc2b03f9527967f6e1e8ff Gerrit-Change-Number: 728 Gerrit-PatchSet: 3 Gerrit-Owner: selvanair <selva.n...@gmail.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Attention: selvanair <selva.n...@gmail.com> Gerrit-Comment-Date: Fri, 06 Sep 2024 10:57:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
