Attention is currently required from: d12fk, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/489?usp=email )
Change subject: Windows: enforce 'block-local' with WFP filters ...................................................................... Patch Set 5: Code-Review-1 (2 comments) Patchset: PS5: Overall the patch does what it says, but it is not -Werror clean. Please fix, rebase (copyright dates have changed for the files renamed and commit 989b22cb6e0 moved around "pipe_message_t" + changed indentation). Thanks. File src/openvpn/init.c: http://gerrit.openvpn.net/c/openvpn/+/489/comment/a60e11c6_446166ef : PS5, Line 2058: unsigned long adapter_index; This is not `-Werror` clean. GH builds complain ``` init.c:2115:26: error: variable 'adapter_index' is uninitialized when used here [-Werror,-Wuninitialized] 68 del_wfp_block(c, adapter_index); 69 ^~~~~~~~~~~~~ 70 init.c:2047:32: note: initialize the variable 'adapter_index' to silence this warning 71 unsigned long adapter_index; 72 ^ 73 = 0 74 1 error generated. ``` This is trivially adjusted (`=0`) but according to project rules I can't do that. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/489?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ic9bf797bfc7e2d471998a84cb0f071db3e4832ba Gerrit-Change-Number: 489 Gerrit-PatchSet: 5 Gerrit-Owner: d12fk <he...@openvpn.net> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: stipa <lstipa...@gmail.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: d12fk <he...@openvpn.net> Gerrit-Comment-Date: Sat, 18 May 2024 16:08:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
