On Fri, Mar 15, 2024 at 05:20:11PM +0100, Frank Lichtenheld wrote: > From: 5andr0 <sandro.tria...@gmail.com> > > So far --server-poll-timeout was only applied > for HTTP proxies, apply it also to SOCKS proxies. > > This removes the default 5 second socks connect timeout > which can be too small depending on network setup and > replaces it with the configurable overall connect timeout > (default 120 seconds). > > Trac: #328 > Change-Id: I2b109f8c551c23045a1be355778b08f0fd4d309f > Signed-off-by: 5andr0 <sandro.tria...@gmail.com> > --- > src/openvpn/socket.c | 2 ++ > src/openvpn/socks.c | 25 ++++++++++++++----------- > src/openvpn/socks.h | 2 ++ > 3 files changed, 18 insertions(+), 11 deletions(-) > > Trying to move this forward by adding a commit message.
Acked-by: Frank Lichtenheld <fr...@lichtenheld.com> Code looks good and I tested build and default t_client tests. However, not sure how exactly to verify that it actually works. The SOCKS proxy I have doesn't exhibit any problems even with --connect-timeout 1. Any ideas for testing welcome. Regards, -- Frank Lichtenheld _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
