Attention is currently required from: flichtenheld, plaisthos. its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/523?usp=email )
Change subject: Http-proxy: fix bug preventing proxy credentials caching ...................................................................... Patch Set 2: (4 comments) File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/523/comment/2fba2993_384c818e : PS1, Line 1861: SHOW_BOOL(ce.http_proxy_options->nocache); > This belongs into show_connection_entry like the other o->ce options Acknowledged File src/openvpn/proxy.c: http://gerrit.openvpn.net/c/openvpn/+/523/comment/0fc15362_dde1eff3 : PS1, Line 275: if (!static_proxy_user_pass.defined || (is_first_time && !p->options.nocache) ) > This condition feels wrong to me. […] Acknowledged http://gerrit.openvpn.net/c/openvpn/+/523/comment/eda88547_5919fdf8 : PS1, Line 278: p->options.auth_file, > I think you messed up a rebase on top of > a634cc5eccd55f1d14197da7376bb819bdf72cb6 here. […] Acknowledged http://gerrit.openvpn.net/c/openvpn/+/523/comment/607aa2a9_08aea895 : PS1, Line 546: get_user_pass_http(p); > So previously this forced a reset of the credentials. This you removed. […] Acknowledged -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/523?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia3e06c0832c4ca0ab868c845279fb71c01a1a78a Gerrit-Change-Number: 523 Gerrit-PatchSet: 2 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Mon, 26 Feb 2024 18:29:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
