Attention is currently required from: flichtenheld, plaisthos.

cron2 has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/499?usp=email )

Change subject: --http-proxy-user-pass: allow to specify in either order with 
--http-proxy
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

Patchset:

PS1:
I think this is a reasonable change - it ensures config consistency, and the 
code looks good (not tested).  The compile fails have been spurious and went 
away on re-run.

I'm not sure yet if this should go to 2.6 as well, though.  Maybe, because 
"fixing inconsistent behaviour = bugfix", and "not very intrusive"?



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/499?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6f402db2fb73f1206fbc1139c47d2bf4378376fa
Gerrit-Change-Number: 499
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Mon, 22 Jan 2024 08:28:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to