Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/465?usp=email )
Change subject: Make it more explicit and visible when pkg-config is not found ...................................................................... Patch Set 3: Code-Review-1 (3 comments) Patchset: PS3: Other than the two comments I added in the code, the patch does what it says and it makes very straightforward understanding that pkg-config is now not installed. Tested a couple of cases on my lovely gentoo and it just worked. File configure.ac: http://gerrit.openvpn.net/c/openvpn/+/465/comment/a58bb3dc_c4b892a1 : PS3, Line 385: pkg_config_found="(not found)" am I wrong or there is some indentation havoc here? The line above uses 8blanks tab, but the lines before have 4 spaces indentation? I think we uses tabs everywhere else. http://gerrit.openvpn.net/c/openvpn/+/465/comment/5512845f_c09de864 : PS3, Line 387: pkg_config_found="(using ${PKG_CONFIG})" many error messages already contain 'using pkg-config', therefore the text above will lead to 'using using', which sounds weird. How about changing 'using' with 'path:'? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/465?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iebaa35a23e217a4cd7739af229cbfc08a3d8854a Gerrit-Change-Number: 465 Gerrit-PatchSet: 3 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: ordex <a...@unstable.cc> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Thu, 04 Jan 2024 23:17:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
