On Wed, Dec 20, 2023 at 02:36:37PM +0100, Frank Lichtenheld wrote:
> From: Lev Stipakov <l...@openvpn.net>
>
> Commits
>
> 1c4a47f7 ("wintun: set adapter properties via interactive service")
> 18826de5 ("Set WINS servers via interactice service")
>
> added functionality of add/remove DNS/WINS via interactive
> service, which is used mostly by dco-win and wintun (tap-windows6
> normally uses DHCP). There is a check in code - if DNS/WINS addresses
> are not pushed, nothing is added.
>
> However, due to bug we always attempted to remove DNS/WINS,
> even if nothing was added. Removing WINS, for example, could take
> up to 3 seconds.
>
> This change fixes this by improving check "has DNS/WINS been pushed?".
>
> While on it, convert do_XXX_service() functions to "void" from "bool",
> since we never check their return values.
>
> Change-Id: I21a36d24f8e213c780f55acbe3e4df555c93542a
> Signed-off-by: Lev Stipakov <l...@openvpn.net>
> Acked-by: Frank Lichtenheld <fr...@lichtenheld.com>
> ---
>
> This change was reviewed on Gerrit and approved by at least one
> developer. I request to merge it to master.
Should also be merged to release/2.6
Regards,
--
Frank Lichtenheld
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
