Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/457?usp=email )
Change subject: Implement generating TLS 1.0 PRF using new OpenSSL 3.0 APIs ...................................................................... Patch Set 5: Code-Review-2 (3 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/457/comment/13568f5e_b6cd455d : PS5, Line 13: using OpenSSL 3.0, it gives the same error as with the older API but missing "in FIPS mode"? My understanding is that this still works with "normal" OpenSSL 3? Patchset: PS5: I have my doubts whether this change is worth it if it doesn't actually fixes anything? Anyway, currently not -Werrror clean, so not mergeable right now. File src/openvpn/crypto_openssl.c: http://gerrit.openvpn.net/c/openvpn/+/457/comment/d48aa189_6936623c : PS5, Line 1404: secret, (size_t) secret_len); ../../../src/openvpn/crypto_openssl.c:1404:51: warning: passing argument 2 of ‘OSSL_PARAM_construct_octet_string’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] 1404 | secret, (size_t) secret_len); -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/457?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ic74195a4ed340547c5e862dc2438f95be318c286 Gerrit-Change-Number: 457 Gerrit-PatchSet: 5 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Comment-Date: Tue, 28 Nov 2023 14:00:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
