On Fri, Aug 11, 2023 at 05:35:03PM +0200, Arne Schwabe wrote: > Am 11.08.23 um 17:12 schrieb Gert Doering: > > Hi, > > > > generally good, but... > > > > On Fri, Jul 28, 2023 at 02:40:05PM +0200, Frank Lichtenheld wrote: > > > index 00000000..0620f638 > > > --- /dev/null > > > +++ b/.github/workflows/coverity-scan.yml > > > @@ -0,0 +1,45 @@ > > > +name: coverity-scan > > > +on: > > > + schedule: > > > + - cron: '0 20 * * *' # Daily at 20:00 UTC > > > + workflow_dispatch: > > > > ... not sure this is the best way to approach the run limit, as > > we can have many days with no commits at all, so we'd waste credits. > > > > Maybe cache the last commit ID and only run coverity if this has > > changed? Or run it "on commit", but cache the current day, and only > > run it again on the next commit that's not on the same day? > > > > (My typical workflow is "you folks queue up patches, and then I find > > half a day of free time, and go merge&push as many as I can make sense of") > > You can get that behaviour but it is tricky. You have to resort tricks like > this: https://github.com/orgs/community/discussions/26519 of saving > something to a cache and then reading the cache on the next run and check if > something changed. We can probably implement like that and then trigger on > push too?
I've basically implemented this now in v2 of the patch (just updated to v3 of cache action). This should address the resource waste concern and also remove unnecessary noise. I've still left the action to trigger on schedule instead of push. I think implementing rate limiting based on push is not worth the effort. Especially since it would often mean that if you have multiple pushes per day the end-result is actually likely to be scanned later since the first pushes eat your rate limit. If some changes should be scanned immediately you can always trigger the workflow manually. Otherwise once per day should be fine. Regards, -- Frank Lichtenheld _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
