Attention is currently required from: cron2, flichtenheld, ordex, plaisthos, selvanair.
stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/321?usp=email ) Change subject: Set WINS servers via interactice service ...................................................................... Patch Set 3: (4 comments) File src/openvpnserv/interactive.c: http://gerrit.openvpn.net/c/openvpn/+/321/comment/6605e8bb_4222a8d1 : PS1, Line 1089: * @param action "delete" or "add" > This says "add" but the rest of the function seems to use "set". […] Right. I copypasted it from DNS version which uses add. http://gerrit.openvpn.net/c/openvpn/+/321/comment/b9b566c1_c7e3b460 : PS1, Line 1094: * if action = "set" then "static" is added before $addr > Why are you using "set" here? The documentation (https://learn.microsoft. […] Good point. The reason I use "set" is because I checked the logs of current implementation which uses "set". Idea of multiple WINS servers slipped from my mind. I checked the code and we use "set + static" for the first server and "set" for the rest, if any. Will to the same here. http://gerrit.openvpn.net/c/openvpn/+/321/comment/bf8912f9_5365fe44 : PS1, Line 1406: if (addr_len > 0 || msg->header.type == msg_del_wins_cfg) > Is there ever a case where this would be false? Normally no, but this request comes from unprivileged userspace process, which we probably do not want to trust. http://gerrit.openvpn.net/c/openvpn/+/321/comment/0b1bcdb1_cc02227e : PS1, Line 1436: if (msg->addr_len > 0) > Nitpick: Should be addr_len, not msg->addr_len Should not matter here, copypaste from similar DNS function. But I can change it. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/321?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: release/2.6 Gerrit-Change-Id: I47c22dcb728011dcedaae47cd03a57219e9c7607 Gerrit-Change-Number: 321 Gerrit-PatchSet: 3 Gerrit-Owner: stipa <lstipa...@gmail.com> Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: ordex <a...@unstable.cc> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: selvanair <selva.n...@gmail.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: ordex <a...@unstable.cc> Gerrit-Attention: selvanair <selva.n...@gmail.com> Gerrit-Comment-Date: Mon, 31 Jul 2023 11:28:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
