Am 14.03.23 um 13:21 schrieb selva.n...@gmail.com:
From: Selva Nair <selva.n...@gmail.com>

- With OpenSSL 3.0 and xkey-provider, we use pkcs11h_certificate_signAny_ex()
   which returns EC signature as raw r|s concatenated. But OpenSSL expects
   a DER encoded ASN.1 structure.

   Do this conversion as done in cryptoapi.c. For code re-use, ecdsa_bin2sig()
   is consolidated with sig to DER conversion as ecdsa_bin2der() and
   moved to xkey_helper.c

   In the past when we used OpenSSL hooks installed by pkcs11-helper,
   such a conversion was not required as it was internally handled by
   the library.

Even though the commit is quite long, it is mostly moving the ecdsa_bin2der function into xkey_helper.c. While I have not tested it myself the code changes make sense and look good and we got a positive test report.

Acked-By: Arne Schwabe <a...@rfc2549.org>





_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to