Hi

FTR, I just noticed that the patch is missing an endgrent() call:

On Mon, Mar 6, 2023 at 12:33 AM <selva.n...@gmail.com> wrote:

>
> +    struct group *gr = getgrent();
> +    char **members = NULL;
> +    while (gr)
> +    {
> +        if (gr->gr_gid == gid)
> +        {
> +            /* found the group -- check user is a member */
> +            members = gr->gr_mem;
> +            for (char *s = *members; s && !ret; s++)
> +            {
> +                ret = !strcmp(s, pw->pw_name);
> +            }
> +            break; /* out of the while loop */
> +        }
> +        gr = getgrent();
> +    }
>

          endgrent();


> +#endif /* if defined(HAVE_GETPWUID) && defined(HAVE_GETGRENT) */
> +    return ret;
> +}
> +
>

Will delay v2 depending on the fate of this patch.

Selva
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to