Acked-by: Gert Doering <g...@greenie.muc.de>

I'm not a big fan of adding (cast) to silence compiler warnings,
but this signed/unsigned char * nonsense is really hard to avoid -
casting to (void *) is the right fix here.

I have only test compiled on MinGW - and my MinGW did not warn
about these anyway (maybe not enough -Wthing switches).  But it 
did not break anything, and does not introduce new warnings.

Your patch has been applied to the master and release/2.6 branch.

commit 7acd93a6bef2dd9b660571c29b5f41c8ca351161 (master)
commit e9ae7cee2ca9b9ab78de01f1d3c562610e5624d2 (release/2.6)
Author: Frank Lichtenheld
Date:   Fri Feb 3 20:14:40 2023 +0100

     Windows: fix signedness errors with recv/send

     Signed-off-by: Frank Lichtenheld <fr...@lichtenheld.com>
     Acked-by: Gert Doering <g...@greenie.muc.de>
     Message-Id: <20230203191440.136050-6-fr...@lichtenheld.com>
     URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26144.html
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to