Acked-by: Gert Doering <g...@greenie.muc.de> This patch looks large and complex, but all it does do is "rip out code parts that are inside #ifndef HAVE_XKEY_PROVIDER" (plus add a message as replacement). This is a welcome change, and in line with what we discussed some time ago regarding OpenSSL support for windows builds.
Applying this to the release/2.6 branch is bending the project rules for "what goes into a release branch" slightly, but we're still in 2.6.*0* and there is lots of cleanup going on - and, really, this is "long term support" since we do not intend to ever provide 2.6.x installers with pre-3.0 OpenSSL libraries, so it's (for all "the project" cares) dead code anyway. Noter: this does not break compilation with 1.1.1, just remove cryptoapi support (https://github.com/cron2/openvpn/actions/runs/4174981083). Your patch has been applied to the master and release/2.6 branch. commit 4b28831e07a357476cb31a6f439becff3dc8c842 (master) commit f3dd050ed8d95001107a841fa7779d09f3efb944 (release/2.6) Author: Selva Nair Date: Wed Feb 1 18:03:40 2023 -0500 cryptoapi.c: remove pre OpenSSL-3.01 support Signed-off-by: Selva Nair <selva.n...@gmail.com> Acked-by: Gert Doering <g...@greenie.muc.de> Message-Id: <20230201230340.2268781-1-selva.n...@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26131.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
