On Wed, Jan 11, 2023 at 7:30 PM Antonio Quartulli <a...@unstable.cc> wrote:

> Hi,
>
> for the netlink/sitnl bits: this makes sense to me.
> I agree with Selva that the v6 variant could benefit from the same
> treatment.
>
> However, this patch can also be hacked on its own
>
> Acked-by: Antonio Quartulli <a...@unstable.cc>
>

Not so fast.
As it stands the patch introduces a bug that was not there: existing v6
routes can cause CONENCTED,ROUTE_ERROR instead of CONNECTED,SUCCESS. That's
why I did not ACK it.

Not sure I understand "can also be hacked alone".

Selva
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to