Hi,

On Sun, Dec 11, 2022 at 2:22 PM Marc Becker via Openvpn-devel <
openvpn-devel@lists.sourceforge.net> wrote:

> Change win32 dynamic loader behavior when supplying an absolute path.
> The DLL location is considered/preferred to resolve dependencies.
> Support in pkcs11-helper for loader flag is detected at compile time.
>
> 3rd party DLLs and additional dependencies do not need to be moved to
> the OpenVPN directory or require changes to %PATH% configuration.
>
> The included changes to pkcs11-helper are pending and can be removed as
> soon as a compatible a version is released/referenced.
>
> Signed-off-by: Marc Becker <marc.bec...@astos.de>
> ---
> v2: compress code change an add transitional pkcs11-helper patch
>

Please split this into separate patches for
#1 changes to pkcs11.c which will be required even after
upstream pkcs11-helper library is updated
#2 Patching pkcs11-helper in vcpkg-ports

Rationale:
(1) #2 can be independently reverted when longer required
(2) IMO, carrying around patches to external libraries is an undue burden
and not justified in this case --- my personal preference would be to NAK
it but still keep #1 as it will automatically get enabled when upstream
pkcs11-helper accepts your changes, which look imminent.

Selva
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to