From: Selva Nair <selva.n...@gmail.com>
- Fixes a potential mis-behaviour (strncpy with
dest == src) introduced by commits ecad4839c (2.6)
and 3d792ae955 (2.5).
Reported by: Gert Doering <g...@greenie.muc.de>
Signed-off-by: Selva Nair <selva.n...@gmail.com>
---
src/openvpn/ssl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/openvpn/ssl.c b/src/openvpn/ssl.c
index 3106c738..24e8ba63 100644
--- a/src/openvpn/ssl.c
+++ b/src/openvpn/ssl.c
@@ -2180,7 +2180,7 @@ key_method_2_write(struct buffer *buf, struct tls_multi
*multi, struct tls_sessi
goto error;
}
/* save username for auth-token which may get pushed later */
- if (session->opt->pull)
+ if (session->opt->pull && up != &auth_token)
{
strncpynt(auth_token.username, up->username, USER_PASS_LEN);
}
--
2.30.2
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
