Hi,

On Thu, Sep 22, 2022 at 10:39 AM Lev Stipakov <lstipa...@gmail.com> wrote:

> From: Lev Stipakov <l...@openvpn.net>
>
> Add a simple python script which generates header with
> branch name and commit hash #defines.
>
> While on it, fix filename in msvc-generate.vcxproj
> and add proper copyright header to Makefile.mak.
>
> Signed-off-by: Lev Stipakov <l...@openvpn.net>
> ---
>  v2:
>
>   - fix copyright year 2002 -> 2022
>   - change "not-a-git-repo" to "unknown"
>
>
...

--
> 2.23.0.windows.1


I have only tested that the script generates config-version.h matching what
./configure builds.
Based on that, the patch looks good to me.

I'm assuming release openvpn.exe is built from a named branch within
openvpn git-repo. Checking out a tag (detached head) and building will get
unknown/unknown. We could probably improve that by using the commit-id even
when the branch name is not available.

Selva
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to