On Mittwoch, 24. August 2022 14:58:58 CEST Arne Schwabe wrote:
> Patch v3: cleanup parse_auth_failed_temp to use a simple const string
> instead of a buffer
Besides the pending rebase and the one code smell below:
Acked-by: Heiko Hund <he...@ist.eigentlich.net>
> src/openvpn/openvpn.vcxproj.filters | 3 +
This file is gone in the meantime
> src/openvpn/ssl.c | 13 ++--
Doesn't apply to master anymore
> +parse_auth_failed_temp(struct options *o, const char *reason)
> +{
> + struct gc_arena gc = gc_new();
> + /* skip TEMP */
> + const char *message = reason + strlen("TEMP");
This should be checked more. Or probably better, "reason" should be passed
from the outside as "reason + 4".
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
