Hi, On 09/09/2022 14:18, Lev Stipakov wrote:
From: Lev Stipakov <l...@openvpn.net>Following options are set on startup and cannot be changed later: - dev - dev-type - connections list - mode - topology Same for system-wide availability of dco. dco_check_option_conflict(), where those options were checked, is also called in server mode when client is connected. Move those checks to dco_check_startup_option_conflict() which is only called at startup. Since we moved dco_enabled() check to startup, dco_check_option_conflict() might now trigger exit on Windows if system lacks chachapoly support. Since dco checks only need to be performed for dco, wrap those into "if (dco_enabled) {}". Signed-off-by: Lev Stipakov <l...@openvpn.net>
Reordering the checks this way makes more sense and helps keeping the code cleaner. When a CCD file is loaded, we now only check options that can only be in there.
Anything that cannot be changed by a CCD file is only checked at startup. Acked-by: Antonio Quartulli <a...@unstable.cc> Cheers, -- Antonio Quartulli _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
