On Tue, Aug 23, 2022 at 02:09:02PM +0200, Timo Rothenpieler wrote: > The ubuntu-18.04 base image is deprecated and in the process of being phased > out: > https://github.blog/changelog/2022-08-09-github-actions-the-ubuntu-18-04-actions-runner-image-is-being-deprecated-and-will-be-removed-by-12-1-22/ > > It is already causing build failures during the scheduled periods mentioned > in the blog post. > > This is the best alternative I found which does not drop any tests or test > environments. > Sadly GHAs build-in container-capabilities can't be used, since they don't > allow specifying --network host. > Without that, IPv6 related tests fail, since the Docker deployment on GHA > does not support IPv6, even in 2022: > https://github.com/actions/runner-images/issues/668 > > So instead this manually invokes docker to run the tests in the respective > Ubuntu Docker-Image. > Some dependencies had to be added since the Docker-Images are more barebones > than the Github-Runner images. > Otherwise, nothing about the test setup changed. > --- > .github/workflows/build.yaml | 43 ++++++++++++++++++++---------------- > 1 file changed, 24 insertions(+), 19 deletions(-) >
Basically the question seems to be whether this increase in complexity is worth it for the additional coverage of the OpenSSL 1.0.2 case. Given that these builds are redundant with the buildbot builds we do, that seems dubious to me. However, the github actions are accessible by people outside of the project, so they are definitely not completely redundant. Regards, -- Frank Lichtenheld _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
