I had to apply a bit of pressure to get the patch to apply - it had
one hunk trying to fix an #endif which never existed :-) - and the context
of the last tun.c hunk needed adjustment (if (tun_dco_enabled(tt))) -
both fairly trivial, and no actual code change.
Pushed to the new and renovated buildbot army, to see if it would break
any platforms (very convenient, this ;-) ).
The change is as we have discussed, and I still think it's a good and
clean way forward. The "undo_ifconfig_ipv4() / _ipv6()" functions
are as they have been before (except that they now get compiled for
all platforms except WIN32 - the "linux only" part was a 2.5.0 oversight),
and the calls moved 1:1 from (TARGET_LINUX) close_tun() to a new
undo_ifconfig() function. tun.c is still a mess, but this helps a bit.
While staring at the diff, I kicked a spurious blank line from the
end of undo_ifconfig()... :-)
Your patch has been applied to the master branch.
commit 054f60fc5eaeacb90333e6b5e183459eb39a6d4f
Author: Max Fillinger
Date: Wed Jun 29 19:05:55 2022 +0200
Don't undo ifconfig on exit if it wasn't done
Signed-off-by: Max Fillinger <maximilian.fillin...@foxcrypto.com>
Acked-by: Antonio Quartulli <anto...@openvpn.net>
Message-Id: <20220629170555.116087-1-maximilian.fillin...@foxcrypto.com>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24610.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
