Hi, On Thu, Aug 18, 2022 at 12:09:53PM +0200, Antonio Quartulli wrote: > At the moment dco-win doesn't support --persist-tun and --server, > so check for these options at startup time. > > Signed-off-by: Antonio Quartulli <a...@unstable.cc> > Signed-off-by: Lev Stipakov <l...@openvpn.net>
I was about to merge this (and thank you for bearing with a grumpy
old man's preferences ;-) - but I really think that the difference
in these platforms need to stand out right there...).
Butbut...
This breaks Linux/Non-DCO builds with --dev tun30, and I can't see
an obvious reason *why*
$ src/openvpn/openvpn --version
OpenVPN 2.6_git [git:vw/master/f10c870c140bd3c6] x86_64-pc-linux-gnu [SSL (mbed
TLS)] [LZO] [LZ4] [EPOLL] [MH/PKTINFO] [AEAD] built on Aug 18 2022
(no DCO here, this is "master + 2/7 v103", on Linux)
$ openvpn ... --dev tun30 --proto udp ...
...
2022-08-18 21:43:52 OPTIONS IMPORT: peer-id set
2022-08-18 21:43:52 OPTIONS IMPORT: data channel crypto options modified
2022-08-18 21:43:52 net_route_v4_best_gw query: dst 0.0.0.0
2022-08-18 21:43:52 net_route_v4_best_gw result: via 195.30.8.94 dev ens160
2022-08-18 21:43:52 GDG6: remote_host_ipv6=n/a
2022-08-18 21:43:52 net_route_v6_best_gw query: dst ::
2022-08-18 21:43:52 net_route_v6_best_gw result: via 2001:608:1:995a::ffff dev
ens160
2022-08-18 21:43:52 DCO device tun30 opened
2022-08-18 21:43:52 net_iface_mtu_set: rtnl: cannot get ifindex for tun30: No
such device (errno=19)
2022-08-18 21:43:52 Linux can't set mtu (1500) on tun30
2022-08-18 21:43:52 Exiting due to fatal error
why is it talking about DCO here? Why would it even *know* about DCO
in a non-DCO build?
Not sure why any of the hunks in this patch have an effect, but if I
go back to the current master, --dev tun30 works, both with and without
--enable-dco.
*scratch head*
Ow.
+#if defined(TARGET_LINUX) && defined(TARGET_FREEBSD)
/* check if any option should force disabling DCO */
-#if defined(TARGET_LINUX) || defined(TARGET_FREEBSD)
this is not "just moving" these lines, but requiring "LEENUX AND FREEBSD"
now...
You owe me a beer :-)
(Changing the && to || makes the --dev tun30 test pass again - I'm
still not sure *what* happened here... but maybe we should reconsider
the decision to have disable_dco default to "false" even on non-DCO
builds...)
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
