Am 18.08.22 um 16:39 schrieb Heiko Hund:
Patch and thus series doesn't apply anymore, in addition to eventual changes
also please rebase.
On Freitag, 20. Mai 2022 23:32:47 CEST Arne Schwabe wrote:
+ If both server and client support sending this message using the control
+ channel, the message will be sent as control-channel message. Otherwise
+ the message is sent as data-channel message, which will be ignored by
+ data-channel offloaded peers.
+
The **n** parameter (default :code:`1` if not present) controls the
maximum number of attempts that the client will try to resend the exit
- notification message.
+ notification message if messages are sent in data-channel mode.
You don't need the "n" for the control channel exit notification because of
the reliability layer, right?!
+ if (proto & IV_PROTO_CC_EXIT_NOTIFY)
+ {
+ o->data_channel_crypto_flags |= CO_USE_CC_EXIT_NOTIFY;
+ }
The flags variable is named confusingly now. Is renaming an option?
Yes it is. But it is also still fitting, because it is affecting data
channel to not send it via this :P
static void
process_explicit_exit_notification_init(struct context *c)
{
msg(M_INFO, "SIGTERM received, sending exit notification to peer");
event_timeout_init(&c->c2.explicit_exit_notification_interval, 1, 0);
reset_coarse_timers(c);
Do we need to timer event if !cc_exit_notify_enabled(c)?
Iirc yes. The timer will will trigger the dealyed exit.
Arne
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
