Acked-by: Gert Doering <g...@greenie.muc.de>

This goes hand in hand with commit 383a897a5cb040d065689 in the ovpn-dco
repo ("require peer VPN IPs only in multipoint mode").  If the kernel does
no longer want this from us, no need to have it here.

Also, the kernel change fixes the edge case I found (ipv4-only without
route-gateway = breaks DCO setup).

So, upgraded the kernel, old openvpn -> "3a" fixed

New openvpn with this patch -> all tests still pass :-)  (that is: client
side DCO tests = p2p mode, and also server side DCO tests = p2mp mode - 
which are not touched by this code, but by the new kernel code)

This also takes care of the older patch from Frank Lichtenheld
("do not warn about missing default gw", PW ID 2646) as this rips out 
much more than just the warning - very good :-)

Your patch has been applied to the master branch.

commit da758e6d7f4298d835ceadd60e60309acc032ee7
Author: Antonio Quartulli
Date:   Tue Aug 16 00:39:41 2022 +0200

     dco: don't pass VPN IPs to NEW_PEER API in P2P mode

     Signed-off-by: Antonio Quartulli <a...@unstable.cc>
     Acked-by: Gert Doering <g...@greenie.muc.de>
     Message-Id: <20220815223941.26839-...@unstable.cc>
     URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24940.html
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to