Acked-by: Gert Doering <g...@greenie.muc.de>

Looks like a reasonable change (so, feature-ACK), and stare-at-code
agrees.

Basically, this renames OPT_P_IPWIN32 to OPT_P_DHCPDNS and mechanically 
changes this in all the code, adds "DNS" to the --route-nopull help text,
and changes the "dns" permissions from DEFAULT to DHCPDNS - which is
the only "real" code change.

I do not have a working windows build environment right now, so I pushed
to my GH repo and let GHA build this - which is all green, so I didn't
overlook anything.

Your patch has been applied to the master branch.

commit 8a7d0005860d2227c8d0e63ee73131e8188b7c18
Author: Arne Schwabe
Date:   Wed Aug 17 09:59:25 2022 +0200

     Rename OPT_P_IPWIN32 to OPT_P_DHCPDNS and include --dns in it

     Acked-by: Gert Doering <g...@greenie.muc.de>
     Message-Id: <20220817075925.815184-1-a...@rfc2549.org>
     URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24946.html
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to