Acked-by: Gert Doering <[email protected]>
Stared at the code, stared at the diff, the changes are what I asked
for (thanks :-) ). I'm sure we'll find more stuff to polish, but I want
this to proceed so the merge conflict with dco-win can be fixed by
rebasing that other tree... (which is needed anyway).
Uncrustify complained about a few tab-vs-space things, which I adjusted
(mostly in ovpn_dco_freebsd.h).
I have also adjusted the "TCP is bah" message to be more in line with
the other "does not work with DCO" messages:
+ msg(msglevel, "NOTE: TCP transport disables data channel offload on
FreeBSD.");
(and indeed, this is what it does -> tests 1* succeed now)
I have tested this on Linux and FreeBSD "without DCO" (full client and
server test, though there is no actual new code that would be compiled
for Linux or for non-DCO FreeBSD), Linux "with DCO" (works), and
FreeBSD 14 with DCO enabled, which looks good, besides the "double fragment
fails" issue - which is not a userland thing.
So far I have only tested the client side (p2p), the server side needs
the iroute patch in 2/2 for full test coverage - "soon".
Your patch has been applied to the master branch.
commit f08fcc2f1eb15941292d6e4e520642a4e474fd1e
Author: Kristof Provost
Date: Fri Aug 12 15:41:53 2022 +0200
ovpn-dco: introduce FreeBSD data-channel offload support
Signed-off-by: Kristof Provost <[email protected]>
Acked-by: Gert Doering <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg24894.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
