Acked-by: Gert Doering <[email protected]>

We really want to check "pushed options", so we should do this when
we actually have --pull in our config :-)

Stared at code (ok), and tested on DCO build with DCO kernel, with the
three scenarios

  - client, normal operation -> works
  - client, with "--pull-filter ignore peer-id" (-> triggers message)
  - server, connecting clients -> annoying message is gone now

Your patch has been applied to the master branch.

commit f9ef554a5bda5c354e59261f9dbf6519e2815388
Author: Antonio Quartulli
Date:   Fri Aug 5 17:08:37 2022 +0200

     dco: perform pull options check only if we pulled any option

     Signed-off-by: Antonio Quartulli <[email protected]>
     Acked-by: Gert Doering <[email protected]>
     Message-Id: <[email protected]>
     URL: 
https://www.mail-archive.com/[email protected]/msg24824.html
     Signed-off-by: Gert Doering <[email protected]>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to