Hi,

On Fri, Jun 24, 2022 at 10:37:50AM +0200, Antonio Quartulli wrote:
> Signed-off-by: Antonio Quartulli <a...@unstable.cc>
> ---
>  src/openvpn/init.c       | 49 ++++++++++++++++++++++++++++++++--------
>  src/openvpn/ssl_common.h | 23 +++++++++++++++++++
>  2 files changed, 63 insertions(+), 9 deletions(-)

Without trying to understand the code flow in init.c, is there a
deeper reason why this happens twice?

> @@ -1708,6 +1717,12 @@ do_open_tun(struct context *c)
>      /* initialize (but do not open) tun/tap object */
>      do_init_tun(c);
>  
> +    /* inherit the dco context from the tuntap object */
> +    if (c->c2.tls_multi)
> +    {
> +        c->c2.tls_multi->dco = &c->c1.tuntap->dco;
> +    }
> +
[..]

> @@ -2979,12 +2999,20 @@ do_init_crypto_tls(struct context *c, const unsigned 
> int flags)
[..]
>      /*
>       * Initialize OpenVPN's master TLS-mode object.
>       */
>      if (flags & CF_INIT_TLS_MULTI)
>      {
>          c->c2.tls_multi = tls_multi_init(&to);
> +        /* inherit the dco context from the tuntap object */
> +        if (c->c1.tuntap)
> +        {
> +            c->c2.tls_multi->dco = &c->c1.tuntap->dco;
> +        }
>      }

... and here again, but only sometimes?

gert
-- 
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             g...@greenie.muc.de

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to