Hi, On Tue, Jun 28, 2022 at 05:46:40PM +0200, Heiko Hund wrote: > On Dienstag, 28. Juni 2022 17:07:14 CEST Gert Doering wrote: > > Uncrustify has complained at me when I merged the patch (because in that > > moment, ovpn_dco_linux.h was "newly modified" and the exclusion rule > > does not match on the pre-commit-hook) - but as discussed, this is a bit > > complicated due to "kernel style" vs "openvpn style", so I've left it > > alone for the moment. > > That's something which needs to be improved. Who is > dev-tools/special-files.lst > intended for? Can uncrustify read it?
We have dev-tools/reformat-all.sh which was used for the "Grand Reformat"
commits - that one reads the special-files.lst, which can contain
"E: <exclude this file>" or some other magic stuff for "pre/post-patch
because uncrustify is stupid".
Having the pre-commit-hook honour the E: exclusion lines would certainly
make handling these files a bit easier - but then, I do not expect updates
to them very often, so this is not super high priority.
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
