NACK, doesn't build: mtu.c: In function ‘frame_calculate_default_mtu’: mtu.c:223:31: error: too few arguments to function ‘frame_calculate_payload_overhead’ 223 | size_t payload_overhead = frame_calculate_payload_overhead(0, &options, &kt); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ mtu.c:111:1: note: declared here 111 | frame_calculate_payload_overhead(const struct frame *frame, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ make[3]: *** [Makefile:754: mtu.o] Error 1
On Tue, Jun 21, 2022 at 06:16:47PM +0200, Arne Schwabe wrote: > We could also just hardcode this value to 1420 but this approach does > not add much (complicated) code and it is a bit better than to have > a magic number to just be there. > > Signed-off-by: Arne Schwabe <a...@rfc2549.org> > --- > src/openvpn/mtu.c | 22 ++++++++++++++++++++++ > src/openvpn/mtu.h | 14 ++++++++++++++ > tests/unit_tests/openvpn/test_crypto.c | 19 ++++++++++++++++++- > 3 files changed, 54 insertions(+), 1 deletion(-) _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel