> Frank Lichtenheld <fr...@lichtenheld.com> hat am 29.04.2022 15:18 geschrieben: > > Frank Lichtenheld <fr...@lichtenheld.com> hat am 29.04.2022 15:11 > > geschrieben: > > > Arne Schwabe <a...@rfc2549.org> hat am 22.04.2022 16:29 geschrieben: > [...] > > > diff --git a/tests/unit_tests/openvpn/test_pkt.c > > > b/tests/unit_tests/openvpn/test_pkt.c > > > index c4e23521d..184b88383 100644 > > > --- a/tests/unit_tests/openvpn/test_pkt.c > > > +++ b/tests/unit_tests/openvpn/test_pkt.c > > > @@ -531,7 +531,7 @@ test_generate_reset_packet_plain(void **ut_state) > > > > > > uint8_t header = 0 | (P_CONTROL_HARD_RESET_CLIENT_V2 << > > > P_OPCODE_SHIFT); > > > > > > - struct buffer buf = tls_reset_standalone(&tas, &client_id, > > > &server_id, header); > > > + struct buffer buf = tls_reset_standalone(&tas, &client_id, > > > &server_id, header, 0, 0); > > > > Nitpick: the second 0 should be "false" instead. Same for all further calls > > in this file. > > Note: fixed in 23/28
Note: the issue here is worse than I initially assumed. Not only should the second 0 be false, the first 0 is just completely wrong, since the second new parameter was added as the first parameter. So the UT is actually broken in 22/28 and needs the fix from 23/28: [ RUN ] test_generate_reset_packet_plain [ ERROR ] --- ASSERT: buf_write(&buf, &net_pid, sizeof(net_pid)) [ LINE ] --- ../../../src/openvpn/ssl_pkt.c:444: error: Failure! [ FAILED ] test_generate_reset_packet_plain [ RUN ] test_generate_reset_packet_tls_auth [ ERROR ] --- ASSERT: buf_write(&buf, &net_pid, sizeof(net_pid)) [ LINE ] --- ../../../src/openvpn/ssl_pkt.c:444: error: Failure! [ FAILED ] test_generate_reset_packet_tls_auth Regards, -- Frank Lichtenheld _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
